Skip to content

Update JS SDK target to es2017#96

Merged
jakubno merged 2 commits intomainfrom
update-tsup-target-to-es2017
Apr 30, 2025
Merged

Update JS SDK target to es2017#96
jakubno merged 2 commits intomainfrom
update-tsup-target-to-es2017

Conversation

@dobrac
Copy link
Copy Markdown
Contributor

@dobrac dobrac commented Apr 29, 2025

Updates the JS SDK target to es2017 (from es2015). This change improves error logs that include user code. This is happening because before es2017 (e.g. es2015) tsup adds polyfill for async (which we use in the API) obfuscating the code execution path.

(The previously generated code)

var __async = (__this, __arguments, generator) => {
  return new Promise((resolve, reject) => {
    var fulfilled = (value) => {
      try {
        step(generator.next(value));
      } catch (e) {
        reject(e);
      }
    };
    var rejected = (value) => {
      try {
        step(generator.throw(value));
      } catch (e) {
        reject(e);
      }
    };
    var step = (x) => x.done ? resolve(x.value) : Promise.resolve(x.value).then(fulfilled, rejected);
    step((generator = generator.apply(__this, __arguments)).next());
  });
};
var __await = function(promise, isYieldStar) {
  this[0] = promise;
  this[1] = isYieldStar;
};

@dobrac dobrac added the improvement Improvement for current functionality label Apr 29, 2025
@dobrac dobrac self-assigned this Apr 29, 2025
@jakubno jakubno merged commit 2ee6ffb into main Apr 30, 2025
4 checks passed
@jakubno jakubno deleted the update-tsup-target-to-es2017 branch April 30, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

@0div 0div Awaiting requested review from 0div

@mishushakov mishushakov Awaiting requested review from mishushakov mishushakov is a code owner

Assignees

@dobrac dobrac

Labels

improvement Improvement for current functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dobrac @jakubno